linux-kernel - Re: [PATCH v4] hwrng: add Zhaoxin rng driver base on rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202312261505.rDaQJwAq-lkp@intel.com>
Date: Tue, 26 Dec 2023 15:49:22 +0800
From: kernel test robot <lkp@...el.com>
To: LeoLiu-oc <LeoLiu-oc@...oxin.com>, olivia@...enic.com,
	herbert@...dor.apana.org.au, jiajie.ho@...rfivetech.com,
	conor.dooley@...rochip.com, martin@...ser.cx, mmyangfl@...il.com,
	jenny.zhang@...rfivetech.com, robh@...nel.org,
	l.stelmach@...sung.com, ardb@...nel.org,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, CobeChen@...oxin.com,
	TonyWWang@...oxin.com, YunShen@...oxin.com, LeoLiu@...oxin.com,
	LeoLiuoc <LeoLiu-oc@...oxin.com>
Subject: Re: [PATCH v4] hwrng: add Zhaoxin rng driver base on rep_xstore
 instruction

Hi LeoLiu-oc,

kernel test robot noticed the following build errors:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on char-misc/char-misc-next char-misc/char-misc-linus herbert-cryptodev-2.6/master linus/master v6.7-rc7 next-20231222]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/LeoLiu-oc/hwrng-add-Zhaoxin-rng-driver-base-on-rep_xstore-instruction/20231225-153520
base:   char-misc/char-misc-testing
patch link:    https://lore.kernel.org/r/20231225025330.809554-1-LeoLiu-oc%40zhaoxin.com
patch subject: [PATCH v4] hwrng: add Zhaoxin rng driver base on rep_xstore instruction
config: i386-randconfig-141-20231225 (https://download.01.org/0day-ci/archive/20231226/202312261505.rDaQJwAq-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231226/202312261505.rDaQJwAq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312261505.rDaQJwAq-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/char/hw_random/via-rng.c:220:26: error: redefinition of 'via_rng_cpu_id' with a different type: 'struct x86_cpu_id[]' vs 'const struct x86_cpu_id[]'
   static struct x86_cpu_id via_rng_cpu_id[] = {
                            ^
   drivers/char/hw_random/via-rng.c:38:32: note: previous definition is here
   static const struct x86_cpu_id via_rng_cpu_id[];
                                  ^
>> drivers/char/hw_random/via-rng.c:224:1: error: definition of variable with array type needs an explicit size or an initializer
   MODULE_DEVICE_TABLE(x86cpu, via_rng_cpu_id);
   ^
   include/linux/module.h:244:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
   extern typeof(name) __mod_##type##__##name##_device_table               \
                       ^
   <scratch space>:56:1: note: expanded from here
   __mod_x86cpu__via_rng_cpu_id_device_table
   ^
   drivers/char/hw_random/via-rng.c:38:32: warning: tentative array definition assumed to have one element
   static const struct x86_cpu_id via_rng_cpu_id[];
                                  ^
   1 warning and 2 errors generated.


vim +220 drivers/char/hw_random/via-rng.c

   219	
 > 220	static struct x86_cpu_id via_rng_cpu_id[] = {
   221		X86_MATCH_VENDOR_FAM_FEATURE(CENTAUR, 6, X86_FEATURE_XSTORE, NULL),
   222		{}
   223	};
 > 224	MODULE_DEVICE_TABLE(x86cpu, via_rng_cpu_id);
   225	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki