linux-kernel - Re: [v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Ilitek ili2901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b415e6d7-d69f-4fc8-8b4f-13e942859ead@linaro.org>
Date: Tue, 26 Dec 2023 10:09:39 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com>,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: dmitry.torokhov@...il.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, jikos@...nel.org,
 benjamin.tissoires@...hat.com, dianders@...omium.org
Subject: Re: [v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for
 Ilitek ili2901

On 26/12/2023 03:37, xiazhengqiao wrote:
> Because ilitek, ili2901 needs to use reset to pull down the time for 10ms,
> so we need to control the reset, use this drive control.

I don't see relation between commit msg and the patch itself. Perhaps
you wanted to say you document new device which is different than elan one?

Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.

> 
> Signed-off-by: xiazhengqiao <xiazhengqiao@...qin.corp-partner.google.com>

Your name still does not look like in other reply.

> ---
>  Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

What supplies does the device have? Not the driver, the device as
written in datasheet?

Best regards,
Krzysztof