linux-kernel - Re: [PATCH v3 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5AmpdE2uMgx8+P-zXf8mYRvsJDBUf7xeRpaHC3jN-7_ww@mail.gmail.com>
Date: Tue, 26 Dec 2023 10:24:32 -0300
From: Fabio Estevam <festevam@...il.com>
To: Mathieu Othacehe <othacehe@....org>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, NXP Linux Team <linux-imx@....com>, Li Yang <leoyang.li@....com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93

On Sun, Dec 24, 2023 at 9:41 AM Mathieu Othacehe <othacehe@....org> wrote:

> +/{
> +       model = "Variscite VAR-SOM-MX93 on Symphony evaluation board";
> +       compatible = "variscite,var-som-mx93-symphony",
> +                    "variscite,var-som-mx93", "fsl,imx93";
> +
> +       aliases {
> +               ethernet1 = &fec;

You could pass ethernet0 here as well.


> +&lpi2c1 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;

These are present in imx93.dtsi. You can drop them from here.

> +&lpi2c5 {
> +       #address-cells = <1>;
> +       #size-cells = <0>;

Ditto.

Reviewed-by: Fabio Estevam <festevam@...il.com>