linux-kernel - Re: [RFC 16/16] riscv: dts: starfive: jh8100: Add clocks and resets nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Dec 2023 14:38:44 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sia Jee Heng <jeeheng.sia@...rfivetech.com>, kernel@...il.dk,
 conor@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 mturquette@...libre.com, sboyd@...nel.org, p.zabel@...gutronix.de,
 emil.renner.berthing@...onical.com, hal.feng@...rfivetech.com,
 xingyu.wu@...rfivetech.com
Cc: linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 leyfoon.tan@...rfivetech.com
Subject: Re: [RFC 16/16] riscv: dts: starfive: jh8100: Add clocks and resets
 nodes

On 26/12/2023 06:38, Sia Jee Heng wrote:
> Add SYSCRG/SYSCRG-NE/SYSCRG-NW/SYSCRG-SW/AONCRG clock and reset
> nodes for JH8100 RISC-V SoC.
> 
> Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> ---

...

>  		compatible = "simple-bus";
>  		interrupt-parent = <&plic>;
> @@ -357,6 +563,99 @@ uart4: serial@...a0000  {
>  			status = "disabled";
>  		};
>  
> +		necrg: necrg@...20000 {

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof