linux-kernel - Re: HID: bpf: One function call less in call_hid_bpf_rdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b75d66cc-a507-432a-af60-655950671b8a@web.de>
Date: Wed, 27 Dec 2023 09:19:27 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Hou Tao <houtao@...weicloud.com>, bpf@...r.kernel.org,
 linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Alexei Starovoitov <ast@...nel.org>,
 Benjamin Tissoires <benjamin.tissoires@...hat.com>,
 David Vernet <void@...ifault.com>, Jiri Kosina <jikos@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr
Subject: Re: HID: bpf: One function call less in call_hid_bpf_rdesc_fixup()
 after error detection

>> The kfree() function was called in one case by the
>> call_hid_bpf_rdesc_fixup() function during error handling
>> even if the passed data structure member contained a null pointer.
>> This issue was detected by using the Coccinelle software.
>
> It is totally OK to free a null pointer through kfree() and the ENOMEM
> case is an unlikely case, so I don't think the patch is necessary.

Would you ever like to avoid redundant data processing a bit more?

Regards,
Markus