lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAA+D8APY3KL6+7kpeqGLm-n_gLTLHOWvMoEZxhrRH2X+9O1d-w@mail.gmail.com> Date: Wed, 27 Dec 2023 18:13:51 +0800 From: Shengjiu Wang <shengjiu.wang@...il.com> To: Chancel Liu <chancel.liu@....com> Cc: Xiubo.Lee@...il.com, festevam@...il.com, nicoleotsuka@...il.com, lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-sound@...r.kernel.org Subject: Re: [PATCH] ASoC: fsl_rpmsg: Fix error handler with pm_runtime_enable On Mon, Dec 25, 2023 at 4:06 PM Chancel Liu <chancel.liu@....com> wrote: > > There is error message when defer probe happens: > > fsl_rpmsg rpmsg_audio: Unbalanced pm_runtime_enable! > > Fix the error handler with pm_runtime_enable. > > Fixes: b73d9e6225e8 ("ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg") > Signed-off-by: Chancel Liu <chancel.liu@....com> Acked-by: Shengjiu Wang <shengjiu.wang@...il.com> Best regards wang shengjiu > --- > sound/soc/fsl/fsl_rpmsg.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/fsl/fsl_rpmsg.c b/sound/soc/fsl/fsl_rpmsg.c > index 5c5c04ce9db7..00852f174a69 100644 > --- a/sound/soc/fsl/fsl_rpmsg.c > +++ b/sound/soc/fsl/fsl_rpmsg.c > @@ -238,7 +238,7 @@ static int fsl_rpmsg_probe(struct platform_device *pdev) > ret = devm_snd_soc_register_component(&pdev->dev, &fsl_component, > &fsl_rpmsg_dai, 1); > if (ret) > - return ret; > + goto err_pm_disable; > > rpmsg->card_pdev = platform_device_register_data(&pdev->dev, > "imx-audio-rpmsg", > @@ -248,16 +248,22 @@ static int fsl_rpmsg_probe(struct platform_device *pdev) > if (IS_ERR(rpmsg->card_pdev)) { > dev_err(&pdev->dev, "failed to register rpmsg card\n"); > ret = PTR_ERR(rpmsg->card_pdev); > - return ret; > + goto err_pm_disable; > } > > return 0; > + > +err_pm_disable: > + pm_runtime_disable(&pdev->dev); > + return ret; > } > > static void fsl_rpmsg_remove(struct platform_device *pdev) > { > struct fsl_rpmsg *rpmsg = platform_get_drvdata(pdev); > > + pm_runtime_disable(&pdev->dev); > + > if (rpmsg->card_pdev) > platform_device_unregister(rpmsg->card_pdev); > } > -- > 2.42.0 >
Powered by blists - more mailing lists