linux-kernel - Re: [PATCH v3 1/4] dt-bindings: mfd: sophgo: add MFD subsys support for Sophgo CV1800 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJRtX8RBER6eit11dEwqMHwaQQwk=0cK12Z7vRArUME3rJ_s6w@mail.gmail.com>
Date: Wed, 27 Dec 2023 19:41:56 +0800
From: Jingbao Qiu <qiujingbao.dlmu@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: a.zummo@...ertech.it, alexandre.belloni@...tlin.com, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor@...nel.org, conor+dt@...nel.org, 
	chao.wei@...hgo.com, unicorn_wang@...look.com, paul.walmsley@...ive.com, 
	palmer@...belt.com, aou@...s.berkeley.edu, linux-rtc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dlan@...too.org, 
	inochiama@...look.com
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: sophgo: add MFD subsys support
 for Sophgo CV1800 series SoC

On Wed, Dec 27, 2023 at 7:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 27/12/2023 08:35, Jingbao Qiu wrote:
> >>
> >> I do not see any resources in MFD block, so why having it as separate
> >> node? What other devices you did not describe here? You mentioned
> >> restart and 8051, so where are they? Which driver implements them?
> >>
> >
> > I'am sorry for that other drivers have not been implemented yet. I
> > will implement it
> > after rtc. They have the same address range, so I use mfd to describe them.
>
> Bindings should be complete even if your driver is not ready. After
> looking at such device node, I say you do not need that rtc child. If
> you sent complete bindings, then of course discussion would be
> different, but...

Thank you for your patient explanation. I will supplement it completely
in the next version

Best regards,
Jingbao Qiu

>
> Best regards,
> Krzysztof
>