lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1adf1fc6-1b9d-4174-beac-5b6b9edb4dd7@linaro.org> Date: Wed, 27 Dec 2023 12:50:15 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Josua Mayer <josua@...id-run.com>, Andrew Lunn <andrew@...n.ch>, Gregory Clement <gregory.clement@...tlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org> Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 2/8] dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards On 26/12/2023 19:11, Josua Mayer wrote: > Add DT compatible for SolidRun Armada-385 based Clearfog GTR L8 and S4 > boards. > > Despite similar name these two boards are designed differently from the > armada 388 clearfog base and pro, they only share a name and general use > case. > > Signed-off-by: Josua Mayer <josua@...id-run.com> > --- > Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > index 5af222e6db18..5bc69c4fe34d 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -30,4 +30,12 @@ properties: > - const: marvell,armada385 > - const: marvell,armada380 > > + - description: SolidRun Armada 385 based single-board computers > + items: > + - enum: > + - solidrun,clearfog-gtr-l8 When I pointed out in your previous versions that you do not test patches, I did it in hope to encourage testing patches... Standard boiler plate: It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
Powered by blists - more mailing lists