linux-kernel - Re: [syzbot] [bluetooth?] WARNING in l2cap_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231227115014.1612-1-hdanton@sina.com>
Date: Wed, 27 Dec 2023 19:50:13 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+d6cd076b385aefcb6b16@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [bluetooth?] WARNING in l2cap_do_send (2)

On Tue, 26 Dec 2023 14:54:27 -0800
> HEAD commit:    fbafc3e621c3 Merge tag 'for_linus' of git://git.kernel.org..
> git tree:       upstream
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14125c81e80000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master

--- x/net/bluetooth/hci_core.c
+++ y/net/bluetooth/hci_core.c
@@ -3237,7 +3237,13 @@ void hci_send_acl(struct hci_chan *chan,
 
 	hci_queue_acl(chan, &chan->data_q, skb, flags);
 
-	queue_work(hdev->workqueue, &hdev->tx_work);
+	rcu_read_lock();
+	if (test_bit(HCI_RESET, &hdev->flags) ||
+	    hci_dev_test_flag(hdev, HCI_CMD_DRAIN_WORKQUEUE))
+		;
+	else
+		queue_work(hdev->workqueue, &hdev->tx_work);
+	rcu_read_unlock();
 }
 
 /* Send SCO data */
--