lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e9541a57-07de-456a-a12f-7f09482fbbc4@linaro.org> Date: Wed, 27 Dec 2023 13:00:57 +0100 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Frank Li <Frank.li@....com> Cc: bhelgaas@...gle.com, conor+dt@...nel.org, devicetree@...r.kernel.org, festevam@...il.com, helgaas@...nel.org, hongxing.zhu@....com, imx@...ts.linux.dev, kernel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org, kw@...ux.com, l.stach@...gutronix.de, linux-arm-kernel@...ts.infradead.org, linux-imx@....com, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, lpieralisi@...nel.org, manivannan.sadhasivam@...aro.org, robh@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org Subject: Re: [PATCH v6 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string On 26/12/2023 22:53, Frank Li wrote: >>> DTB_CHECK report error after I remove it. linux,pci-domain is only define >>> in pci, not pci-ep. >> >> Ah, thank you, indeed. >> >>> >>> So I add comments about this. linux,pci-domain was resued ad controller id. >> >> However maybe there is reason why it is not for endpoints. The >> description is saying it is valid only for host bridge, so maybe it >> should not be used for endpoint case? > > EP side, it is not PCI bus. So it is reasonable that linux,pci-doamin not > in EP side. > > iMX6 host driver(and other some host controller drivers) already use it as > "controller id". EP driver is mostly reused with host bridge drivers. I > think needn't create new property such as "controller_id" for EP only. > > A comments should be enough for this case. Hm, ok, seems fine for me. I don't know PCI good enough to judge, so unless Rob or Conor say something else, it looks good. Best regards, Krzysztof
Powered by blists - more mailing lists