linux-kernel - Re: [PATCH] LoongArch: KVM: add a return kvm_own

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b42e66b0-58a1-4408-a3f6-bbbf5254e472@infradead.org>
Date: Tue, 26 Dec 2023 17:15:22 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: linux-kernel@...r.kernel.org, Bibo Mao <maobibo@...ngson.cn>,
 Tianrui Zhao <zhaotianrui@...ngson.cn>, Huacai Chen
 <chenhuacai@...ngson.cn>, WANG Xuerui <kernel@...0n.name>,
 kvm@...r.kernel.org, loongarch@...ts.linux.dev,
 Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] LoongArch: KVM: add a return kvm_own_lasx() stub



On 12/26/23 17:11, Huacai Chen wrote:
> Hi, Randy,
> 
> Could you please fix kvm_own_lsx() together?
> 

Sure will. Thanks.

> Huacai
> 
> On Wed, Dec 27, 2023 at 9:07 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>> The stub for kvm_own_lasx() when CONFIG_CPU_HAS_LASX is not defined
>> should have a return value since it returns an int, so add
>> "return -EINVAL;" to the stub. Fixes the build error:
>>
>> In file included from ../arch/loongarch/include/asm/kvm_csr.h:12,
>>                  from ../arch/loongarch/kvm/interrupt.c:8:
>> ../arch/loongarch/include/asm/kvm_vcpu.h: In function 'kvm_own_lasx':
>> ../arch/loongarch/include/asm/kvm_vcpu.h:73:39: error: no return statement in function returning non-void [-Werror=return-type]
>>    73 | static inline int kvm_own_lasx(struct kvm_vcpu *vcpu) { }
>>
>> Fixes: 118e10cd893d ("LoongArch: KVM: Add LASX (256bit SIMD) support")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Bibo Mao <maobibo@...ngson.cn>
>> Cc: Tianrui Zhao <zhaotianrui@...ngson.cn>
>> Cc: Huacai Chen <chenhuacai@...ngson.cn>
>> Cc: WANG Xuerui <kernel@...0n.name>
>> Cc: kvm@...r.kernel.org
>> Cc: loongarch@...ts.linux.dev
>> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
>> ---


-- 
#Randy