lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231228002603.059bfb1c@echidna> Date: Thu, 28 Dec 2023 00:26:03 +1100 From: David Disseldorp <ddiss@...e.de> To: Qu Wenruo <wqu@...e.com> Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, christophe.jaillet@...adoo.fr, andriy.shevchenko@...ux.intel.com, David.Laight@...LAB.COM Subject: Re: [PATCH 1/3] kstrtox: introduce a safer version of memparse() On Sat, 23 Dec 2023 20:28:05 +1030, Qu Wenruo wrote: > + s = _parse_integer_fixup_radix(s, &base); > + rv = _parse_integer(s, base, &value); > + if (rv & KSTRTOX_OVERFLOW) > + return -ERANGE; > + if (rv == 0) > + return -EINVAL; I was playing around with your unit tests and noticed that "0xG" didn't reach the expected rv == 0 -> -EINVAL above. It seems that _parse_integer_fixup_radix() should handle 0x<non hex> differently, or at least step past any autodetected '0' octal prefix. Cheers, David
Powered by blists - more mailing lists