linux-kernel - Re: [PATCH] gpio: tps65219: don't use CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mfu9tQNTYETtdmXyGtB1Gox7s_AcBwETVinZwR=LWdTLQ@mail.gmail.com>
Date: Wed, 27 Dec 2023 15:57:24 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Tony Lindgren <tony@...mide.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Andy Shevchenko <andy@...nel.org>
Cc: linux-omap@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: tps65219: don't use CONFIG_DEBUG_GPIO

On Thu, Dec 21, 2023 at 7:57 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> CONFIG_DEBUG_GPIO should only be used to enable debug log messages and
> for core GPIOLIB debugging. Don't use it to control the execution of
> potentially buggy code. Just put it under an always-false #if.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  drivers/gpio/gpio-tps65219.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c
> index 7b38aa360112..cd1f17041f8c 100644
> --- a/drivers/gpio/gpio-tps65219.c
> +++ b/drivers/gpio/gpio-tps65219.c
> @@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off
>          * Below can be used for test purpose only.
>          */
>
> -       if (IS_ENABLED(CONFIG_DEBUG_GPIO)) {
> -               int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
> -                                            TPS65219_GPIO0_DIR_MASK, direction);
> -               if (ret) {
> -                       dev_err(dev,
> -                               "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
> -                               direction, offset);
> -                       return ret;
> -               }
> +#if 0
> +       int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
> +                                    TPS65219_GPIO0_DIR_MASK, direction);
> +       if (ret) {
> +               dev_err(dev,
> +                       "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
> +                       direction, offset);
> +               return ret;
>         }
> +#endif
>
>         dev_err(dev,
>                 "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",
> --
> 2.40.1
>

Patch applied.

Bart