lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <0a98d3b6-e0ec-408a-aa2d-f2b23dcff26f@web.de> Date: Wed, 27 Dec 2023 17:02:03 +0100 From: Markus Elfring <Markus.Elfring@....de> To: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr Subject: [PATCH 1/2] nfc: mei_phy: Return directly after a failed kzalloc() in mei_nfc_send() From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Wed, 27 Dec 2023 16:30:20 +0100 The kfree() function was called in one case by the mei_nfc_send() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus return directly after a call of the function “kzalloc” failed at the beginning. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/nfc/mei_phy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nfc/mei_phy.c b/drivers/nfc/mei_phy.c index f9cca885beec..937f229f4646 100644 --- a/drivers/nfc/mei_phy.c +++ b/drivers/nfc/mei_phy.c @@ -208,10 +208,9 @@ static int mei_nfc_send(struct nfc_mei_phy *phy, const u8 *buf, size_t length) u8 *mei_buf; int err; - err = -ENOMEM; mei_buf = kzalloc(length + MEI_NFC_HEADER_SIZE, GFP_KERNEL); if (!mei_buf) - goto out; + return -ENOMEM; hdr = (struct mei_nfc_hdr *)mei_buf; hdr->cmd = MEI_NFC_CMD_HCI_SEND; -- 2.43.0
Powered by blists - more mailing lists