lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <0268aecb00fc4d77858d5eef644d30b4e3fb4a0c.camel@mediatek.com> Date: Wed, 27 Dec 2023 01:58:46 +0000 From: Chunfeng Yun (云春峰) <Chunfeng.Yun@...iatek.com> To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> CC: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "mathias.nyman@...el.com" <mathias.nyman@...el.com>, Eddie Hung (洪正鑫) <Eddie.Hung@...iatek.com>, "stable@...r.kernel.org" <stable@...r.kernel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Macpaul Lin (林智斌) <Macpaul.Lin@...iatek.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>, "angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com> Subject: Re: [PATCH v3 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer On Wed, 2023-12-20 at 06:57 +0100, Greg Kroah-Hartman wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Wed, Dec 20, 2023 at 10:58:41AM +0800, Chunfeng Yun wrote: > > For Gen1 isoc-in transfer, host still send out unexpected ACK after > device > > finish the burst with a short packet, this will cause an exception > on the > > connected device, such as, a usb 4k camera. > > It can be fixed by setting rxfifo depth less than 4k bytes, prefer > to use > > 3k here, the side-effect is that may cause performance drop about > 10%, > > including bulk transfer. > > > > Fixes: 926d60ae64a6 ("usb: xhci-mtk: modify the SOF/ITP interval > for mt8195") > > Cc: stable@...r.kernel.org > > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com> > > --- > > v3: > > add Cc stable > > Why is a patch that you are marking for stable inclusion (and I am > guessing inclusion in 6.7-final) in the middle of other patches that > are > not marked as such? I'll remove Cc. > > Always split out bugfixes from other things so that they can go > through > the two different branches, one for this current release, and one for > the next one. > > Otherwise you will have to wait until 6.8-rc1 for this bugfix to > land, > which I doubt you intend to have happen. > > Please fix up and resend 2 different patch series. Send v3 today, and modify property; Thanks a lot > > thanks, > > greg k-h
Powered by blists - more mailing lists