linux-kernel - Re: [PATCH 01/10] clk: ti: Less function calls in of_omap2_apll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYxTGQyl8vTFTHDo@smile.fi.intel.com>
Date: Wed, 27 Dec 2023 18:38:49 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Michael Turquette <mturquette@...libre.com>,
	Rob Herring <robh@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
	Tero Kristo <kristo@...nel.org>, Tony Lindgren <tony@...mide.com>,
	LKML <linux-kernel@...r.kernel.org>, cocci@...ia.fr
Subject: Re: [PATCH 01/10] clk: ti: Less function calls in
 of_omap2_apll_setup() after error detection

On Sun, Dec 24, 2023 at 05:36:57PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 24 Dec 2023 11:15:27 +0100
> 
> The kfree() function was called in up to three cases by
> the of_omap2_apll_setup() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.

> * Split a condition check.
> 
> * Adjust jump targets.
> 
> * Delete three initialisations which became unnecessary
>   with this refactoring.

Instead, make use of cleanup.h.

-- 
With Best Regards,
Andy Shevchenko