linux-kernel - Re: [PATCH v3 01/24] resource: Add DEFINE_RES_*_NAMED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYxZbt2nx2m1BFeZ@smile.fi.intel.com>
Date: Wed, 27 Dec 2023 19:05:50 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Hasemeyer <markhas@...omium.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Sudeep Holla <sudeep.holla@....com>,
	Raul Rangel <rrangel@...omium.org>,
	Tzung-Bi Shih <tzungbi@...nel.org>,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Baoquan He <bhe@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 01/24] resource: Add DEFINE_RES_*_NAMED_FLAGS macro

On Tue, Dec 26, 2023 at 12:21:05PM -0700, Mark Hasemeyer wrote:
> In some cases, it would be nice to instantiate a struct resource with
> custom flags. For example, creating an IRQ resource with a flag that
> marks the interrupt as wake capable.
> 
> Add a set of macros to provide custom flag arguments.

> Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>

Was it @intel.com? Please, use @linux.intel.com anyway.

> Signed-off-by: Mark Hasemeyer <markhas@...omium.org>

Tag block must _not_ have any blank line(s).

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

While we will have user only for IRQ case, the rest are added for symmetry's
sake, I think it's okay and we might even have more (existing) users to convert
to new macros (at least it rings a bell to me for a few places).

-- 
With Best Regards,
Andy Shevchenko