linux-kernel - Re: [PATCH mm] kasan: stop leaking stack trace handles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231227141005.14e278c3f08dd0d64004dbf7@linux-foundation.org>
Date: Wed, 27 Dec 2023 14:10:05 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Andrey Konovalov <andreyknvl@...il.com>
Cc: kernel test robot <lkp@...el.com>, andrey.konovalov@...ux.dev, Marco
 Elver <elver@...gle.com>, oe-kbuild-all@...ts.linux.dev, Linux Memory
 Management List <linux-mm@...ck.org>, Alexander Potapenko
 <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, Andrey Ryabinin
 <ryabinin.a.a@...il.com>, kasan-dev@...glegroups.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH mm] kasan: stop leaking stack trace handles

On Wed, 27 Dec 2023 22:42:40 +0100 Andrey Konovalov <andreyknvl@...il.com> wrote:

> On Wed, Dec 27, 2023 at 10:23 PM Andrew Morton
> <akpm@...ux-foundation.org> wrote:
> >
> > Thanks, I added this fix:
> >
> > --- a/mm/kasan/generic.c~kasan-stop-leaking-stack-trace-handles-fix
> > +++ a/mm/kasan/generic.c
> > @@ -503,7 +503,7 @@ void kasan_init_object_meta(struct kmem_
> >          */
> >  }
> >
> > -void release_alloc_meta(struct kasan_alloc_meta *meta)
> > +static void release_alloc_meta(struct kasan_alloc_meta *meta)
> >  {
> >         /* Evict the stack traces from stack depot. */
> >         stack_depot_put(meta->alloc_track.stack);
> > @@ -514,7 +514,7 @@ void release_alloc_meta(struct kasan_all
> >         __memset(meta, 0, sizeof(*meta));
> >  }
> >
> > -void release_free_meta(const void *object, struct kasan_free_meta *meta)
> > +static void release_free_meta(const void *object, struct kasan_free_meta *meta)
> >  {
> >         /* Check if free meta is valid. */
> >         if (*(u8 *)kasan_mem_to_shadow(object) != KASAN_SLAB_FREE_META)
> > _
> >
> 
> Could you mark them as "static inline" even?

That's rather old-fashioned.  Nowadays gcc is supposed to work out
whether or not to inline things, and we override that with noinline and
__always_inline.