linux-kernel - Re: [PATCH] x86/syscalls: shrink entry/syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231228004550.GJ1674809@ZenIV>
Date: Thu, 28 Dec 2023 00:45:50 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Tanzir Hasan <tanzirh@...gle.com>
Cc: Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Nick Desaulniers <nnn@...gle.com>
Subject: Re: [PATCH] x86/syscalls: shrink entry/syscall_32.i via IWYU

On Wed, Dec 27, 2023 at 11:34:44PM +0000, Al Viro wrote:

> That's _it_.  The same goes for syscall_64.c and syscall_x32.c.
> Oh, and lose the __visible/asmlinkage junk in there - none of that
> stuff is used from asm these days.  See the patch below -
> Untested But Should Work(tm):

Unfortunately, there's this in kernel/trace/trace_syscalls.c:

unsigned long __init __weak arch_syscall_addr(int nr)
{
        return (unsigned long)sys_call_table[nr];
}

How is that supposed to work for anything biarch?  Including
amd64 with CONFIG_COMPAT enabled?

Confused...