[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eb560b8d-e7e1-4af8-a585-78e50352c8f0@intel.com>
Date: Thu, 28 Dec 2023 16:32:40 +0800
From: Yi Liu <yi.l.liu@...el.com>
To: "Tian, Kevin" <kevin.tian@...el.com>, "joro@...tes.org" <joro@...tes.org>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>, "jgg@...dia.com"
<jgg@...dia.com>, "robin.murphy@....com" <robin.murphy@....com>,
"baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>
CC: "cohuck@...hat.com" <cohuck@...hat.com>, "eric.auger@...hat.com"
<eric.auger@...hat.com>, "nicolinc@...dia.com" <nicolinc@...dia.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "mjrosato@...ux.ibm.com"
<mjrosato@...ux.ibm.com>, "chao.p.peng@...ux.intel.com"
<chao.p.peng@...ux.intel.com>, "yi.y.sun@...ux.intel.com"
<yi.y.sun@...ux.intel.com>, "peterx@...hat.com" <peterx@...hat.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"shameerali.kolothum.thodi@...wei.com"
<shameerali.kolothum.thodi@...wei.com>, "lulu@...hat.com" <lulu@...hat.com>,
"suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>, "Duan,
Zhenzhong" <zhenzhong.duan@...el.com>, "joao.m.martins@...cle.com"
<joao.m.martins@...cle.com>, "Zeng, Xin" <xin.zeng@...el.com>, "Zhao, Yan Y"
<yan.y.zhao@...el.com>, "j.granados@...sung.com" <j.granados@...sung.com>
Subject: Re: [PATCH v8 06/10] iommufd/selftest: Add coverage for
IOMMU_HWPT_INVALIDATE ioctl
On 2023/12/28 14:14, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@...el.com>
>> Sent: Thursday, December 28, 2023 12:14 AM
>>
>> + /* Negative test: trigger error */
>> + num_inv = 1;
>> + inv_reqs[0].flags =
>> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR;
>> + inv_reqs[0].iotlb_id = 0;
>> + test_cmd_hwpt_invalidate(nested_hwpt_id[0], inv_reqs,
>> +
>> IOMMU_HWPT_INVALIDATE_DATA_SELFTEST,
>> + sizeof(*inv_reqs), &num_inv);
>> + assert(num_inv == 1);
>> + assert(inv_reqs[0].hw_error ==
>> IOMMU_TEST_INVALIDATE_FAKE_ERROR);
>> +
>
> instead of removing TRIGGER_ERROR|ALL err check, it makes more
> sense to keep it but making it a similar case as above.
yeah, but the config of TRIGGER_ERROR|ALL would be valid. is it?
Your point is to add another test case to see if "error" is generated
even if there is other flags set. is it?
--
Regards,
Yi Liu
Powered by blists - more mailing lists