linux-kernel - Re: [PATCH V8 3/3] leds: Add support for UP board CPLD onboard LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f02f1a6d-88fe-463b-b3a0-4feb5a6f8c85@kernel.org>
Date: Thu, 28 Dec 2023 16:29:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "larry.lai" <larry.lai@...jingtech.com>, lee@...nel.org,
 andriy.shevchenko@...ux.intel.com, linus.walleij@...aro.org, pavel@....cz
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-leds@...r.kernel.org, GaryWang@...on.com.tw, musa.lin@...jingtech.com,
 jack.chang@...jingtech.com, noah.hung@...jingtech.com
Subject: Re: [PATCH V8 3/3] leds: Add support for UP board CPLD onboard LEDS

On 28/12/2023 16:15, larry.lai wrote:
> The UP boards come with a few FPGA-controlled onboard LEDs:
> * UP Board: yellow, green, red
> * UP Squared: blue, yellow, green, red
> 

...

> +
> +static int upboard_led_probe(struct platform_device *pdev)
> +{
> +	struct upboard_fpga * const cpld = dev_get_drvdata(pdev->dev.parent);
> +	struct reg_field fldconf = {
> +		.reg = UPFPGA_REG_FUNC_EN0,
> +	};
> +	struct upboard_led_data * const pdata = pdev->dev.platform_data;

Your const does not make sense. Please read C standard how qualifiers
are applied.

...

> +module_platform_driver_probe(upboard_led_driver, upboard_led_probe);
> +
> +MODULE_AUTHOR("Gary Wang <garywang@...on.com.tw>");
> +MODULE_DESCRIPTION("UP Board LED driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:upboard-led");

Nothing improved here.

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof