linux-kernel - Re: [PATCH] linux/export: Ensure natural alignment of kcrctab array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 29 Dec 2023 01:32:26 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Helge Deller <deller@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org
Subject: Re: [PATCH] linux/export: Ensure natural alignment of kcrctab array

On Thu, Dec 28, 2023 at 7:36 PM Helge Deller <deller@...nel.org> wrote:
>
> The ___kcrctab section holds an array of 32-bit CRC values.
> Add a .balign 4 to tell the linker the correct memory alignment.
>
> Signed-off-by: Helge Deller <deller@....de>
> Fixes: f3304ecd7f06 ("linux/export: use inline assembler to populate symbol CRCs")
> Link: https://lore.kernel.org/r/CAK7LNAT5gyn0C9EJhh1EeFT7gF0rOudWcdqAVN=+C4jR42W90w@mail.gmail.com/



Applied to linux-kbuild/fixes.
Thanks!





> diff --git a/include/linux/export-internal.h b/include/linux/export-internal.h
> index 69501e0ec239..51b8cf3f60ef 100644
> --- a/include/linux/export-internal.h
> +++ b/include/linux/export-internal.h
> @@ -61,6 +61,7 @@
>
>  #define SYMBOL_CRC(sym, crc, sec)   \
>         asm(".section \"___kcrctab" sec "+" #sym "\",\"a\""     "\n" \
> +           ".balign 4"                                         "\n" \
>             "__crc_" #sym ":"                                   "\n" \
>             ".long " #crc                                       "\n" \
>             ".previous"                                         "\n")



-- 
Best Regards
Masahiro Yamada