linux-kernel - Re: [PATCH v5 05/23] PM: EM: Refactor a new function em_compute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231228171441.jgyjtp3knbtcqgf7@airbuntu>
Date: Thu, 28 Dec 2023 17:14:41 +0000
From: Qais Yousef <qyousef@...alina.io>
To: Lukasz Luba <lukasz.luba@....com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	rafael@...nel.org, dietmar.eggemann@....com, rui.zhang@...el.com,
	amit.kucheria@...durent.com, amit.kachhap@...il.com,
	daniel.lezcano@...aro.org, viresh.kumar@...aro.org,
	len.brown@...el.com, pavel@....cz, mhiramat@...nel.org,
	wvw@...gle.com
Subject: Re: [PATCH v5 05/23] PM: EM: Refactor a new function
 em_compute_costs()

On 12/19/23 10:59, Lukasz Luba wrote:
> 
> 
> On 12/17/23 17:58, Qais Yousef wrote:
> > On 11/29/23 11:08, Lukasz Luba wrote:
> > > Refactor a dedicated function which will be easier to maintain and re-use
> > > in future. The upcoming changes for the modifiable EM perf_state table
> > > will use it (instead of duplicating the code).
> > 
> > nit: What is being refactored? Looks like you took em_compute_cost() out of
> > em_create_perf_table().
> 
> Yes, it's going to be re-used later for also update code path, not only
> register code path.

Sorry I was terse. I meant the commit message could be clearer to require less
effort untangling what is actually being changed.