linux-kernel - Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2b73ac2-c271-d11c-6d06-3e0ab74a29a6@google.com>
Date: Thu, 28 Dec 2023 12:43:30 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
cc: Andrew Morton <akpm@...ux-foundation.org>, 
    Linus Torvalds <torvalds@...ux-foundation.org>, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, rafael@...nel.org, 
    surenb@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
    souravpanda@...gle.com
Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto
 expand the sysfs files)

On Thu, 28 Dec 2023, Pasha Tatashin wrote:

> > > But for existing files and conventions, I think we should settle it as
> > > "keep doing what you've been doing for 13+ years" and don't force this
> > > argument every time a kernel developer wants to just add one more stat.
> >
> > Absolutely.  Let's do what makes most sense.  For new things, one value
> > per file.  For stats which logically group with other existing stats,
> > do whatever the existing other stats are currently doing.
> 
> The intent of "[PATCH] vmstat: don't auto expand the sysfs files" is
> to do exactly this: keep the current fields in
> /sys/devices/system/node/node*/vmstat as-is, but prevent future fields
> added to node_stat, numa_stat, zone_stat from showing in vmstat.
> 

This is the opposite of what Andrew and I wrote above.  There should be no 
need to start preventing future stats from being grouped together in 
vmstat if it logically makes sense.

NAK.