linux-kernel - Re: [PATCH v2] erofs: fix inconsistent per-file compression format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231228100038.00004fdf.zbestahu@gmail.com>
Date: Thu, 28 Dec 2023 10:00:38 +0800
From: Yue Hu <zbestahu@...il.com>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: linux-erofs@...ts.ozlabs.org, Yue Hu <huyue2@...lpad.com>,
 bugreport@...sectech.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] erofs: fix inconsistent per-file compression format

On Wed, 27 Dec 2023 13:06:33 +0800
Gao Xiang <hsiangkao@...ux.alibaba.com> wrote:

> EROFS can select compression algorithms on a per-file basis, and each
> per-file compression algorithm needs to be marked in the on-disk
> superblock for initialization.
> 
> However, syzkaller can generate inconsistent crafted images that use
> an unsupported algorithm for specific inodes; thus, an unexpected
> "BUG: kernel NULL pointer dereference" can be raised.
> 
> Fix this by checking against `sbi->available_compr_algs` for each
> compressed inode.  Incorrect !erofs_sb_has_compr_cfgs preset bitmap
> is now fixed together since it was harmless previously.
> 
> Reported-by: <bugreport@...sectech.com>
> Fixes: 14373711dd54 ("erofs: add on-disk compression configurations")
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Reviewed-by: Yue Hu <huyue2@...lpad.com>