linux-kernel - Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence Multi-Channel I2S Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48943ae1-1d7f-44a6-97de-d2999b5f72a2@starfivetech.com>
Date: Fri, 29 Dec 2023 16:31:44 +0800
From: Xingyu Wu <xingyu.wu@...rfivetech.com>
To: Mark Brown <broonie@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>, Claudiu Beznea
	<Claudiu.Beznea@...rochip.com>, Jaroslav Kysela <perex@...ex.cz>, "Takashi
 Iwai" <tiwai@...e.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
	<conor.dooley@...rochip.com>, Walker Chen <walker.chen@...rfivetech.com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence
 Multi-Channel I2S Controller

On 2023/12/22 20:39, Mark Brown wrote:
> On Fri, Dec 22, 2023 at 05:11:17PM +0800, Xingyu Wu wrote:
>> On 2023/12/21 20:55, Mark Brown wrote:
>> > On Thu, Dec 21, 2023 at 11:32:23AM +0800, Xingyu Wu wrote:
> 
>> >>  sound/soc/starfive/cdns-jh8100-i2s-pcm.c | 262 ++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.c     | 727 +++++++++++++++++++++++
>> >>  sound/soc/starfive/cdns-jh8100-i2s.h     | 171 ++++++
> 
>> > If this is a Cadence IP why is the entire driver SoC specific?
> 
>> This a new driver about this Cadence I2S controller. Should I create a new folder and file like this:
> 
>> sound/soc/cdns/cdns-i2s*
> 
>> and I use different compatible to support other SoC like JH8100?
> 
> Yes, that seems more what I'd expect - with a fallback compatible for
> things that don't need any special quirks.

Okay, I will modify these in next version.

Thanks,
Xingyu Wu