linux-kernel - Re: [PATCH] EDAC: constantify the struct bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023122918-tiring-isolating-3f4a@gregkh>
Date: Fri, 29 Dec 2023 09:10:02 +0000
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Borislav Petkov <bp@...en8.de>
Cc: tony.luck@...el.com, linux-kernel@...r.kernel.org,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org
Subject: Re: [PATCH] EDAC: constantify the struct bus_type usage

On Thu, Dec 28, 2023 at 04:00:03PM +0100, Borislav Petkov wrote:
> On Tue, Dec 19, 2023 at 02:13:10PM +0100, Greg Kroah-Hartman wrote:
> > In many places in the edac code, struct bus_type pointers are passed
> > around and then eventually sent to the driver core, which can handle a
> > constant pointer.  So constantify all of the edac usage of these as well
> > because the data in them is never modified by the edac code either.
> 
> "constantify", huh? Not enough words in the English language so let's do
> new ones?
> 
> :-)

Hey, we could be using German and then it would be something like
"Konstantifizierung" :)

> So what's the plan with this "constantification"?
> 
> Because:
> 
> drivers/edac/edac_module.c: In function ‘edac_subsys_init’:
> drivers/edac/edac_module.c:80:38: warning: passing argument 1 of ‘subsys_system_register’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>    80 |         err = subsys_system_register(&edac_subsys, NULL);
>       |                                      ^~~~~~~~~~~~
> In file included from ./include/linux/edac.h:16,
>                  from drivers/edac/edac_module.c:13:
> ./include/linux/device.h:75:45: note: expected ‘struct bus_type *’ but argument is of type ‘const struct bus_type *’
>    75 | int subsys_system_register(struct bus_type *subsys,
>       |

Ah, oops, that means this depends on a patch in my trees already that
fix this up.  You can wait until after 6.8-rc1 to get to this, or I can
take it in my tree if you want now, which ever is easiest for you.

thanks,

greg k-h