linux-kernel - Re: [PATCH] ALSA: hda/tas2781: do not use regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y1ddxjm0.wl-tiwai@suse.de>
Date: Fri, 29 Dec 2023 13:45:43 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Gergo Koteles <soyer@....hu>
Cc: Shenghao Ding <shenghao-ding@...com>,
	Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: do not use regcache

On Fri, 22 Dec 2023 00:48:56 +0100,
Gergo Koteles wrote:
> 
> There are two problems with using regcache in this module.
> 
> The amplifier has 3 addressing levels (BOOK, PAGE, REG). The firmware
> contains blocks that must be written to BOOK 0x8C. The regcache doesn't
> know anything about BOOK, so regcache_sync writes invalid values to the
> actual BOOK.
> 
> The module handles 2 or more separate amplifiers. The amplifiers have
> different register values, and the module uses only one regmap/regcache
> for all the amplifiers. The regcache_sync only writes the last amplifier
> used.
> 
> The module successfully restores all the written register values (RC
> profile, program, configuration, calibration) without regcache.
> 
> Remove regcache functions and set regmap cache_type to REGCACHE_NONE.
> 
> Link: https://lore.kernel.org/r/21a183b5a08cb23b193af78d4b1114cc59419272.1701906455.git.soyer@irl.hu/
> 
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> CC: stable@...r.kernel.org
> Signed-off-by: Gergo Koteles <soyer@....hu>

Applied to for-linus branch now.  Thanks.


Takashi