linux-kernel - Re: [PATCH 1/3] Fix headset auto detect fail in cx8070 and SN6140

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87a5ptxcos.wl-tiwai@suse.de>
Date: Fri, 29 Dec 2023 16:15:15 +0100
From: Takashi Iwai <tiwai@...e.de>
To: bo liu <bo.liu@...arytech.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Fix headset auto detect fail in cx8070 and SN6140

On Wed, 27 Dec 2023 08:10:06 +0100,
bo liu wrote:
> 
> CX8070 and SN6140 will get wrong headset type when use OMTP headset, then the headset mic will not work.
> 
> Signed-off-by: bo liu <bo.liu@...arytech.com>

Well, the patch series has a serious problem, unfortunately.

Basically the patch that is submitted to the upstream should be in the
final form.  But this series puts the coding style errors and then
corrects multiple times in the series.  This is absolutely no-go.

Create a "perfect patch", and submit it, instead.

For that, you'll need to give a bit more detailed patch description.
Currently it says nothing but the problem.  It doesn't mention how and
what to be fixed / changed.  Ideally speaking, the patch should have a
description that is self-explanatory.

Last but not least, please put the proper subject prefix.
In your case, it'd be like "ALSA: hda/conexant:".

Please try to address the above points and resubmit.

thanks,

Takashi