linux-kernel - Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Dec 2023 15:38:41 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Malkoot Khan <engr.mkhan1990@...il.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/cma: Move opening brace to next line for coding
 style

On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote:
> Move the opening brace of a function definition 'cma_for_each_area'
> to the next line which resolved the error

What error?  This seems like the _wrong_ coding style to me.

> Signed-off-by: Malkoot Khan <engr.mkhan1990@...il.com>
> ---
>  mm/cma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 2b2494fd6b59..01ccd26e8bc2 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages,
>  }
>  
>  int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
> +
>  {
>  	int i;
>  
> -- 
> 2.34.1
> 
>