linux-kernel - Re: [PATCH] scsi: ses: Move a label in ses_enclosure_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50978c86-cf4a-991d-54ab-50d8d977f946@inria.fr>
Date: Fri, 29 Dec 2023 18:29:02 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: James Bottomley <jejb@...ux.ibm.com>
cc: Markus Elfring <Markus.Elfring@....de>, linux-scsi@...r.kernel.org, 
    kernel-janitors@...r.kernel.org, 
    "Martin K. Petersen" <martin.petersen@...cle.com>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ses: Move a label in
 ses_enclosure_data_process()



On Fri, 29 Dec 2023, James Bottomley wrote:

> On Thu, 2023-12-28 at 15:48 +0100, Markus Elfring wrote:
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Thu, 28 Dec 2023 15:38:09 +0100
> >
> > The kfree() function was called in up to three cases by
> > the ses_enclosure_data_process() function during error handling
> > even if the passed variable contained a null pointer.
> > This issue was detected by using the Coccinelle software.
>
> Why is this an issue?  The whole point of having kfree(NULL) be a nop
> is so we don't have to special case the free path.  The reason we do
> that is because multiple special case paths through code leads to more
> complex control flows and more potential bugs.  If coccinelle suddenly
> thinks this is a problem, it's coccinelle that needs fixing.

Coccinelle doesn't think anything.  Markus for some reason thinks it's a
problem and uses Coccinelle to find occurrences of it.

julia