linux-kernel - Re: [PATCH 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Dec 2023 18:46:30 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Daniel Vetter <daniel@...ll.ch>, 
	David Airlie <airlied@...il.com>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Sam Ravnborg <sam@...nborg.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK

Hi Dario,

On Fri, Dec 29, 2023 at 2:52 PM Dario Binacchi
<dario.binacchi@...rulasolutions.com> wrote:

> The initialization commands are taken from the STMicroelectronics driver
> found at https://github.com/STMicroelectronics/STM32CubeF7/blob/master/Drivers/BSP/Components/nt35510/
>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

NAK.

Please rewrite the patch to use the detailed instructions with clear definitions
about what is going on the same way as in the old driver, and add #defines
for all the magic commands, and break down the commands to what they
are actually doing with the display hardware.

Magic display init sequences are not OK in this driver, and not in general,
it is all the other drivers that are just unaware about what they are doing
and this driver actually isn't.

Yours,
Linus Walleij