linux-kernel - Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023123027-baffling-arise-63bf@gregkh>
Date: Sat, 30 Dec 2023 11:43:46 +0000
From: Greg KH <greg@...ah.com>
To: Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	maple-tree@...ts.infradead.org, akpm@...ux-foundation.org,
	willy@...radead.org, liam.howlett@...cle.com,
	zhangpeng.00@...edance.com, stable@...r.kernel.org
Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot
 stores

On Mon, Dec 18, 2023 at 09:53:53AM -0800, Sidhartha Kumar wrote:
> On 12/18/23 2:59 AM, Greg KH wrote:
> > On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote:
> > > mas_preallocate() defaults to requesting 1 node for preallocation and then
> > > ,depending on the type of store, will update the request variable. There
> > > isn't a check for a slot store type, so slot stores are preallocating the
> > > default 1 node. Slot stores do not require any additional nodes, so add a
> > > check for the slot store case that will bypass node_count_gfp(). Update
> > > the tests to reflect that slot stores do not require allocations.
> > > 
> > > User visible effects of this bug include increased memory usage from the
> > > unneeded node that was allocated.
> > > 
> > > Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing")
> > > Cc: <stable@...r.kernel.org> # 6.6+
> > > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>
> > > ---
> > > This is a modified backport as the patch to fix this in upstream does not
> > > apply to 6.6 because the node_end field was moved from the ma_wr_state to
> > > the ma_state after 6.6.
> > 
> > What is the git commit id of this change in Linus's tree?
> 
> The patch is in akpm's mm-hotfixes-unstable tree and has not made it to
> Linus's tree yet.

Ok, please resend when it hits Linus's tree.