linux-kernel - Re: [PATCH wireless 2/5] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231230144036.7f48b739@barney>
Date: Sat, 30 Dec 2023 14:40:36 +0100
From: Michael Büsch <m@...s.ch>
To: Julian Calaby <julian.calaby@...il.com>
Cc: Rahul Rameshbabu <sergeantsagara@...tonmail.com>, Kalle Valo
 <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
 b43-dev@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH wireless 2/5] wifi: b43: Stop/wake correct queue in DMA
 Tx path when QoS is disabled

On Sat, 30 Dec 2023 18:48:45 +1100
Julian Calaby <julian.calaby@...il.com> wrote:
> > --- a/drivers/net/wireless/broadcom/b43/dma.c
> > +++ b/drivers/net/wireless/broadcom/b43/dma.c
> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff *skb)
> >             should_inject_overflow(ring)) {
> >                 /* This TX ring is full. */
> >                 unsigned int skb_mapping = skb_get_queue_mapping(skb);
> > -               ieee80211_stop_queue(dev->wl->hw, skb_mapping);
> > +               if (dev->qos_enabled)
> > +                       ieee80211_stop_queue(dev->wl->hw, skb_mapping);
> > +               else
> > +                       ieee80211_stop_queue(dev->wl->hw, 0);  
> 
> Would this be a little cleaner if we only look up the queue mapping if
> QOS is enabled? I.e.

No. It would break the other uses of skb_mapping.

But I am wondering why skb_mapping is non-zero in the first place.
I think the actual bug might be somewhere else.

-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped