linux-kernel - Re: [PATCH V8 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <639fb3c8-6ead-409c-b06c-1e3158f716a8@kernel.org>
Date: Sat, 30 Dec 2023 15:09:29 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jack Chang <jack.chang@...jingtech.com>,
 "larry.lai" <larry.lai@...jingtech.com>, lee@...nel.org,
 andriy.shevchenko@...ux.intel.com, linus.walleij@...aro.org, pavel@....cz
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-leds@...r.kernel.org, GaryWang@...on.com.tw, musa.lin@...jingtech.com,
 noah.hung@...jingtech.com
Subject: Re: [PATCH V8 2/3] pinctrl: Add support pin control for UP board
 CPLD/FPGA

On 29/12/2023 10:18, Jack Chang wrote:
> On 2023/12/28 23:28, Krzysztof Kozlowski wrote:
>> On 28/12/2023 16:15, larry.lai wrote:
>>> The UP Squared board <http://www.upboard.com> implements certain
>>> features (pin control) through an on-board FPGA.
> 
> ...
> 
>>> +MODULE_ALIAS("platform:upboard-pinctrl");
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
> 
> add "platform:" for auto probe these two drivers when upboard-fpga
> has probe and register these 2 drivers.

Why do you use alias instead of missing ID table? This scales poorly.
Use ID table and if you disagree, then respond with proper comment. You
just replied something obvious.

Best regards,
Krzysztof