lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9a4da75c-b6cf-0ee4-ef3b-5e19af6cb144@huaweicloud.com> Date: Sat, 30 Dec 2023 14:33:30 +0800 From: Li Nan <linan666@...weicloud.com> To: linan666@...weicloud.com, richard@....at, miquel.raynal@...tlin.com, vigneshr@...com Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, yukuai3@...wei.com, yi.zhang@...wei.com, houtao1@...wei.com, yangerkun@...wei.com Subject: Re: [PATCH v2] ubi: block: fix memleak in ubiblock_create() friendly ping... 在 2023/12/8 15:46, linan666@...weicloud.com 写道: > From: Li Nan <linan122@...wei.com> > > If idr_alloc() fails, dev->gd will be put after goto out_cleanup_disk in > ubiblock_create(), but dev->gd has not been assigned yet at this time, and > 'gd' will not be put anymore. Fix it by putting 'gd' directly. > > Signed-off-by: Li Nan <linan122@...wei.com> > Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com> > --- > Changes in v2: > - modify the description of the problem in log > > drivers/mtd/ubi/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c > index 309a42aeaa4c..654bd7372cd8 100644 > --- a/drivers/mtd/ubi/block.c > +++ b/drivers/mtd/ubi/block.c > @@ -434,7 +434,7 @@ int ubiblock_create(struct ubi_volume_info *vi) > list_del(&dev->list); > idr_remove(&ubiblock_minor_idr, gd->first_minor); > out_cleanup_disk: > - put_disk(dev->gd); > + put_disk(gd); > out_free_tags: > blk_mq_free_tag_set(&dev->tag_set); > out_free_dev: -- Thanks, Nan
Powered by blists - more mailing lists