[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <36eac3a4-bca9-4648-9154-7a0561476f9f@collabora.com>
Date: Sat, 30 Dec 2023 12:20:03 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>, brendan.higgins@...ux.dev,
davidgow@...gle.com, rmoar@...gle.com
Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>,
linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com
Subject: Re: [PATCH] kunit: Fix NULL-dereference in kunit_init_suite() if
suite->log is NULL
On 12/18/23 8:17 PM, Richard Fitzgerald wrote:
> suite->log must be checked for NULL before passing it to
> string_stream_clear(). This was done in kunit_init_test() but was missing
> from kunit_init_suite().
>
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 6d696c4695c5 ("kunit: add ability to run tests after boot using debugfs")
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
> lib/kunit/test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> index e803d998e855..ea7f0913e55a 100644
> --- a/lib/kunit/test.c
> +++ b/lib/kunit/test.c
> @@ -658,7 +658,9 @@ static void kunit_init_suite(struct kunit_suite *suite)
> kunit_debugfs_create_suite(suite);
> suite->status_comment[0] = '\0';
> suite->suite_init_err = 0;
> - string_stream_clear(suite->log);
> +
> + if (suite->log)
> + string_stream_clear(suite->log);
> }
>
> bool kunit_enabled(void)
--
BR,
Muhammad Usama Anjum
Powered by blists - more mailing lists