linux-kernel - Re: [PATCH v4 2/2] hwmon: (lm75) Add AMS AS6200 temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca786cac-aa83-4795-8b91-ee85b07bdcfa@roeck-us.net>
Date: Sun, 31 Dec 2023 10:17:04 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Abdel Alkuor <alkuor@...il.com>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 2/2] hwmon: (lm75) Add AMS AS6200 temperature sensor

On Sat, Dec 23, 2023 at 11:21:59AM -0500, Abdel Alkuor wrote:
> as6200 is a temperature sensor with 0.0625°C resolution and a
> range between -40°C to 125°C.
> 
> By default, the driver configures as6200 as following:
> - Converstion rate: 8 Hz
> - Conversion mode: continuous
> - Consecutive fault counts: 4 samples
> - Alert state: high polarity
> - Alert mode: comparator mode
> 
> Interrupt is supported for the alert pin.
> 
> Datasheet: https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf
> Signed-off-by: Abdel Alkuor <alkuor@...il.com>

Applied. Side note below.

> +    Datasheet: Publicly available at the AMS website
> +
> +               https://ams.com/documents/20143/36005/AS6200_DS000449_4-00.pdf

Apparently checkpatch doesn't like this way of pointing to a datasheet anymore
and reacts with a warning, demanding the use of Link: or similar.
I don't think this is appropriate, so I guess we see the first instance of
to-be-ignored checkpatch warnings ins the hwmon subsystem.

Guenter