linux-kernel - Re: [PATCH 1/4] netlink: Improve exception handling in __netlink_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jan 2024 10:13:48 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, Anjali Kulkarni
 <anjali.k.kulkarni@...cle.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Kuniyuki Iwashima <kuniyu@...zon.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] netlink: Improve exception handling in
 __netlink_kernel_create()

On Sun, 31 Dec 2023 18:42:30 +0100
Markus Elfring <Markus.Elfring@....de> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 31 Dec 2023 17:26:41 +0100
> 
> The kfree() function was called in one case by
> the __netlink_kernel_create() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> Thus use another label.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

NAK
Please look at something else, calling kfree(NULL) is correct
and the preferred solution.