linux-kernel - Re: [PATCH 03/13] mm: Provide generic pmd_thp_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4B38660D-3AC2-4F96-9DD1-2D8CAA55E7E4@linux.dev>
Date: Tue, 2 Jan 2024 14:30:25 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Peter Xu <peterx@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Linux-MM <linux-mm@...ck.org>,
 Matthew Wilcox <willy@...radead.org>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Lorenzo Stoakes <lstoakes@...il.com>,
 David Hildenbrand <david@...hat.com>,
 Vlastimil Babka <vbabka@...e.cz>,
 Mike Kravetz <mike.kravetz@...cle.com>,
 Mike Rapoport <rppt@...nel.org>,
 Christoph Hellwig <hch@...radead.org>,
 John Hubbard <jhubbard@...dia.com>,
 Andrew Jones <andrew.jones@...ux.dev>,
 linux-arm-kernel@...ts.infradead.org,
 Michael Ellerman <mpe@...erman.id.au>,
 "Kirill A . Shutemov" <kirill@...temov.name>,
 linuxppc-dev@...ts.ozlabs.org,
 Rik van Riel <riel@...riel.com>,
 linux-riscv@...ts.infradead.org,
 Yang Shi <shy828301@...il.com>,
 James Houghton <jthoughton@...gle.com>,
 "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Jason Gunthorpe <jgg@...dia.com>,
 Andrea Arcangeli <aarcange@...hat.com>,
 Axel Rasmussen <axelrasmussen@...gle.com>
Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()

> On Jan 2, 2024, at 13:37, Peter Xu <peterx@...hat.com> wrote:
> 
> On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
>>> @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
>>>  #endif /* pmd_write */
>>>  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>>> +#ifndef pmd_thp_or_huge
>> 
>> I think it may be the time to rename to pmd_thp_or_hugetlb,
>> the "huge" is really confusing. thp is not huge? Actually,
>> it is huge. It is better to make it more specific from now on, like
>> "hugetlb".
> 
> The rename will need to touch ARM code, which I wanted to avoid, see:

I see.

> 
> arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd)   (pmd_huge(pmd) || pmd_trans_huge(pmd))
> 
> So far this series only touches generic code.  Would you mind I keep this
> patch as-is, and leave renaming to later?

OK.

THanks.

> 
>> 
>> BTW, please cc me via the new email (muchun.song@...ux.dev) next edition.
> 
> Sure.  Thanks for taking a look.
> 
> -- 
> Peter Xu
>