lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 2 Jan 2024 08:38:28 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Suman Ghosh <sumang@...vell.com>,
 "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
 Alexandra Winter <wintera@...ux.ibm.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] net/iucv: Improve unlocking in iucv_enable()

> @@ -555,13 +555,16 @@ static int iucv_enable(void)
>> 	if (cpumask_empty(&iucv_buffer_cpumask))
>> 		/* No cpu could declare an iucv buffer. */
>> 		goto out;
>> +
>> +	rc = 0;
>> +unlock:
>> 	cpus_read_unlock();
>> -	return 0;
>> +	return rc;
>> +
>> out:
>> 	kfree(iucv_path_table);
>> 	iucv_path_table = NULL;
>> -	cpus_read_unlock();
>> -	return rc;
>> +	goto unlock;
> [Suman] This looks confusing. What is the issue with retaining the original change?

I propose to reduce the number of cpus_read_unlock() calls
(in the source code).

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ