linux-kernel - Re: [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c2c42f6-e10a-4ff1-89c7-8635b8f8b73e@collabora.com>
Date: Tue, 2 Jan 2024 10:13:54 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Eugen Hristev <eugen.hristev@...labora.com>, tiffany.lin@...iatek.com,
 andrew-ct.chen@...iatek.com, matthias.bgg@...il.com,
 linux-mediatek@...ts.infradead.org
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 robh+dt@...nel.org, kernel@...labora.com, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix
 non-vp8 clock name

Il 28/12/23 12:32, Eugen Hristev ha scritto:
> Looking at the binding it makes sense that the `-vp8` compatible has
> the `venc_lt_sel` while the other bindings have the `venc_sel` as name for
> the clock.
> This was also mentioned in the txt version of the binding before the
> conversion:
>   `
>   clock-names: avc encoder must contain "venc_sel", vp8 encoder must
>   contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2",
>   `
> 
> So it is easier to check for compatible that includes vp8, since that's
> just one, to have the requirement for the clock name property as
> `venc_lt_sel`, rather than for all the others, some of which are missing,
> thus for them, the requirement is wrongly `venc_lt_sel`.
> 
> Reordered the if/then/else to match `-vp8` and have all the rest of
> the compatibles using the other clock name (`venc_sel`).
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> Reviewed-by: Rob Herring <robh@...nel.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>