linux-kernel - Re: [PATCH 12/12] mailbox: zynqmp-ipi: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Jan 2024 10:36:06 +0100
From: Michal Simek <michal.simek@....com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Jassi Brar <jassisinghbrar@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kernel@...gutronix.de
Subject: Re: [PATCH 12/12] mailbox: zynqmp-ipi: Convert to platform remove
 callback returning void



On 12/27/23 22:02, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>   drivers/mailbox/zynqmp-ipi-mailbox.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 7fa533e80dd9..610a92f9c0b2 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -688,19 +688,17 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int zynqmp_ipi_remove(struct platform_device *pdev)
> +static void zynqmp_ipi_remove(struct platform_device *pdev)
>   {
>   	struct zynqmp_ipi_pdata *pdata;
>   
>   	pdata = platform_get_drvdata(pdev);
>   	zynqmp_ipi_free_mboxes(pdata);
> -
> -	return 0;
>   }
>   
>   static struct platform_driver zynqmp_ipi_driver = {
>   	.probe = zynqmp_ipi_probe,
> -	.remove = zynqmp_ipi_remove,
> +	.remove_new = zynqmp_ipi_remove,
>   	.driver = {
>   		   .name = "zynqmp-ipi",
>   		   .of_match_table = of_match_ptr(zynqmp_ipi_of_match),

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal