linux-kernel - Re: [2/2] virtiofs: Improve error handling in virtio_fs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b27d89d-c410-4898-b801-00d2a00fb693@web.de>
Date: Tue, 2 Jan 2024 11:47:38 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Matthew Wilcox <willy@...radead.org>, virtualization@...ts.linux.dev,
 linux-fsdevel@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: Miklos Szeredi <miklos@...redi.hu>, Stefan Hajnoczi
 <stefanha@...hat.com>, Vivek Goyal <vgoyal@...hat.com>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [2/2] virtiofs: Improve error handling in virtio_fs_get_tree()

> Do you consider more clarity in your argumentation?

It is probably clear that the function call “kfree(NULL)” does not perform
data processing which is really useful for the caller.
Such a call is kept in some cases because programmers did not like to invest
development resources for its avoidance.

Regards,
Markus