linux-kernel - Re: [PATCH v1 1/1] drm/virtio: Spelling fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0617eeeb-c0af-4ab0-8ae1-e87ba0044948@collabora.com>
Date: Thu, 4 Jan 2024 00:08:10 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 dri-devel@...ts.freedesktop.org, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: David Airlie <airlied@...hat.com>, Gerd Hoffmann <kraxel@...hat.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v1 1/1] drm/virtio: Spelling fixes

On 12/19/23 18:19, Andy Shevchenko wrote:
> While making a spelling mistake myself for `git grep kvalloc`
> I found that the only file has such a typo. Fix it and update
> to the standard de facto of how we refer to the functions.
> Also spell usr-out as user-out, it seems this driver uses its
> own terminology nobody else can decypher, make it more readable.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_submit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_submit.c b/drivers/gpu/drm/virtio/virtgpu_submit.c
> index 5c514946bbad..1c7c7f61a222 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_submit.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_submit.c
> @@ -99,8 +99,8 @@ virtio_gpu_parse_deps(struct virtio_gpu_submit *submit)
>  		return 0;
>  
>  	/*
> -	 * kvalloc at first tries to allocate memory using kmalloc and
> -	 * falls back to vmalloc only on failure. It also uses __GFP_NOWARN
> +	 * kvmalloc() at first tries to allocate memory using kmalloc() and
> +	 * falls back to vmalloc() only on failure. It also uses __GFP_NOWARN
>  	 * internally for allocations larger than a page size, preventing
>  	 * storm of KMSG warnings.
>  	 */
> @@ -529,7 +529,7 @@ int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data,
>  	virtio_gpu_submit(&submit);
>  
>  	/*
> -	 * Set up usr-out data after submitting the job to optimize
> +	 * Set up user-out data after submitting the job to optimize
>  	 * the job submission path.
>  	 */
>  	virtio_gpu_install_out_fence_fd(&submit);

Applied to misc-next, thanks

-- 
Best regards,
Dmitry