linux-kernel - Re: [PATCH] perf tools:remove unneeded variable from perf_event_attr_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZZXPdSo38DRTUVj_@kernel.org>
Date: Wed, 3 Jan 2024 18:19:49 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: baomingtong001@...suo.com, peterz@...radead.org, mingo@...hat.com,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, namhyung@...nel.org, adrian.hunter@...el.com,
	anshuman.khandual@....com, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools:remove unneeded variable from
 perf_event_attr__fprintf()

Em Wed, Jul 12, 2023 at 06:20:12PM -0700, Ian Rogers escreveu:
> On Tue, Jun 13, 2023 at 11:25 PM <baomingtong001@...suo.com> wrote:
> >
> > fix the following coccicheck warning:
> >
> > tools/perf/util/perf_event_attr_fprintf.c:97:5-8: Unneeded variable:
> > "ret". Return "0".
> >
> > Signed-off-by: Mingtong Bao <baomingtong001@...suo.com>
> 
> Acked-by: Ian Rogers <irogers@...gle.com>

util/perf_event_attr_fprintf.c: In function ‘perf_event_attr__fprintf’:
util/perf_event_attr_fprintf.c:256:17: error: ‘ret’ undeclared (first use in this function)
  256 |                 ret += attr__fprintf(fp, _n, buf, priv);\
      |                 ^~~
util/perf_event_attr_fprintf.c:267:9: note: in expansion of macro ‘PRINT_ATTRn’
  267 |         PRINT_ATTRn("type", type, p_type_id, true);
      |         ^~~~~~~~~~~

All those PRINT_ATTRf use that ret variable:

#define PRINT_ATTRn(_n, _f, _p, _a)                     \
do {                                                    \
        if (_a || attr->_f) {                           \
                _p(attr->_f);                           \
                ret += attr__fprintf(fp, _n, buf, priv);\
        }                                               \
} while (0)

#define PRINT_ATTRf(_f, _p)     PRINT_ATTRn(#_f, _f, _p, false

- Arnaldo
 
> Thanks,
> Ian
> 
> > ---
> >   tools/perf/util/perf_event_attr_fprintf.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/util/perf_event_attr_fprintf.c
> > b/tools/perf/util/perf_event_attr_fprintf.c
> > index 7e5e7b30510d..4a8f625b80c7 100644
> > --- a/tools/perf/util/perf_event_attr_fprintf.c
> > +++ b/tools/perf/util/perf_event_attr_fprintf.c
> > @@ -94,7 +94,6 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> >                    attr__fprintf_f attr__fprintf, void *priv)
> >   {
> >       char buf[BUF_SIZE];
> > -    int ret = 0;
> >
> >       PRINT_ATTRf(type, p_unsigned);
> >       PRINT_ATTRf(size, p_unsigned);
> > @@ -155,5 +154,5 @@ int perf_event_attr__fprintf(FILE *fp, struct
> > perf_event_attr *attr,
> >       PRINT_ATTRf(aux_sample_size, p_unsigned);
> >       PRINT_ATTRf(sig_data, p_unsigned);
> >
> > -    return ret;
> > +    return 0;
> >   }

-- 

- Arnaldo