linux-kernel - RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bcc45d1d4c914707b81c54cba6f1917e@sk.com>
Date: Wed, 3 Jan 2024 07:36:07 +0000
From: "Hardaway (Shih Hung) Tseng SKHYT" <hardaway.tseng@...com>
To: Keith Busch <kbusch@...nel.org>, Jim Lin 林志融
	<jim.lin@...iconmotion.com>, David Yeh 葉寰融
	<david.yeh@...iconmotion.com>
CC: Jim.Lin <jim.chihjung.lin@...il.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
	"hch@....de" <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	CJ Chen 陳群傑 <cj.chen@...iconmotion.com>,
	한상안(HAN SANGAN) 대만법인
	<sangan.han@...com>, "Ives(Hsueh Hsien) Lu SKHYT" <ives.lu@...com>
Subject: RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Hello Keith,

Hope everything you are doing is well!

These days our teams tried several way to do further verification of this disable write zero patch for BC901, let me summarize as below :

1)	The chrome image with this new write zero disable code built with 5.15, has been verified and passed (< 20min mode switching time)
2)	Due to some limitations, Google team couldn't build a new chrome image with the suggested 6.5 or later version + this disable write zero patch for verification test.
3)	Tried to build image with 5.15 + disable write zero patch + DEAC merged, system can run but the testing result is failed (> 20min mode switching, actually 27~29mins).

Above is all we could do here for the verification of this patch, could you share us your comment or suggestion? Is it possible to merge and do upstream for this patch?

Thank you so much!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@...com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”

Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan
Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@...com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Hardaway (Shih Hung) Tseng SKHYT 
Sent: Wednesday, November 29, 2023 11:51 AM
To: 'Keith Busch' <kbusch@...nel.org>; Jim Lin 林志融 <jim.lin@...iconmotion.com>; David Yeh 葉寰融 <david.yeh@...iconmotion.com>
Cc: Jim.Lin <jim.chihjung.lin@...il.com>; axboe@...nel.dk; hch@....de; sagi@...mberg.me; linux-nvme@...ts.infradead.org; linux-kernel@...r.kernel.org; CJ Chen 陳群傑 <cj.chen@...iconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@...com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@...com>
Subject: RE: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

Hi Keith,

Thanks for head up Christoph's questions!
Our team will help us to answer them.

Hi Jim and David,
Thanks for your support!


Thanks & Regards,
Hardaway.


Hardaway Tseng/ Sr. Manager | SN-FAQE | SK hynix Semiconductor Taiwan
Address: 10F. No. 308, Zhifu Rd., Zhongshan Dist., Taipei City 10466, Taiwan Office : +886-2-3518-2313/ Fax: +886-2-3518-2366/ Mobile: +886-919-803-458
Email: hardaway.tseng@...com

SK hynix Confidential
“This e-mail may contain confidential and/or privileged information. If you are not the intended recipient(or have received this e-mail in error), please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure or distribution of the material in this e-mail is strictly forbidden.”


-----Original Message-----
From: Keith Busch <kbusch@...nel.org>
Sent: Wednesday, November 29, 2023 8:10 AM
To: Hardaway (Shih Hung) Tseng SKHYT <hardaway.tseng@...com>
Cc: Jim Lin 林志融 <jim.lin@...iconmotion.com>; Jim.Lin <jim.chihjung.lin@...il.com>; axboe@...nel.dk; hch@....de; sagi@...mberg.me; linux-nvme@...ts.infradead.org; linux-kernel@...r.kernel.org; CJ Chen 陳群傑 <cj.chen@...iconmotion.com>; David Yeh 葉寰融 <david.yeh@...iconmotion.com>; 한상안(HAN SANGAN) 대만법인 <sangan.han@...com>; Ives(Hsueh Hsien) Lu SKHYT <ives.lu@...com>
Subject: Re: [PATCH] nvme-pci: disable write zeroes for SK Hynix BC901

On Tue, Nov 28, 2023 at 11:51:42PM +0000, hardaway.tseng@...com wrote:
> Hi Keith, Jim and team,
> 
> Thanks for efforts!
> 
> This is Hardaway from SK hynix, this software change has been tested and verified by ODM Compal, the testing result is pass, therefore, we would like to apply this update.

Great, thanks for confirming. I've got this queued up internally, but want to check if Christoph's question could lead to a better outcome for everyone. For reference, asked here:

  https://lists.infradead.org/pipermail/linux-nvme/2023-November/043298.html

If you were already testing close to upstream, 6.2 or newer, then this patch is already the best option.