linux-kernel - Re: [PATCH] nvmem: fix issue within nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240103094013.2672cb7d@xps-13>
Date: Wed, 3 Jan 2024 09:40:13 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: POPESCU Catalin <catalin.popescu@...ca-geosystems.com>
Cc: "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
 "michael@...le.cc" <michael@...le.cc>, "rafal@...ecki.pl"
 <rafal@...ecki.pl>, "robh@...nel.org" <robh@...nel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 GEO-CHHER-bsp-development <bsp-development.geo@...ca-geosystems.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Luca Ceresoli
 <luca.ceresoli@...tlin.com>
Subject: Re: [PATCH] nvmem: fix issue within nvmem_register with
 fixed-layout.

Hi Catalin,

miquel.raynal@...tlin.com wrote on Tue, 5 Dec 2023 10:05:02 +0100:

> Hi Catalin,
> 
> + GKH
> + Luca (who initially reported this issue)
> 
> catalin.popescu@...ca-geosystems.com wrote on Tue, 5 Dec 2023 08:48:27
> +0000:
> 
> > Adding more people.
> > 
> > On 30.11.23 17:29, Catalin Popescu wrote:
> > > fixed-layout is natively supported by NVMEM framework.
> > > Yet, it's not been declared as a supported layout. As a
> > > result, nvmem_register always returns -EPROBE_DEFER if
> > > configuration has no layout and the NVMEM provider DT
> > > uses a fixed layout.
> > >
> > > As a fix, declare fixed-layout as a supported layout
> > > and use add_cells callback to parse the cells. This adds
> > > consistency over layouts parsing as fixed-layout parsing
> > > is handled in the same way than others nvmem layouts.
> 
> I believe this patch (not taken yet) should fix your issue and should be
> queued to fixes.
> 
> Link: https://lore.kernel.org/lkml/20231124193814.360552-1-miquel.raynal@bootlin.com/
> 
> However I like your approach which should probably be taken into
> consideration for the next cycle, as I think it fits Rafal's
> original idea pretty well.

Do you plan on updating this patch at -rc1? I think it would be
interesting to follow your idea.

Thanks,
Miquèl