[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024010332-sermon-snowy-cf47@gregkh>
Date: Wed, 3 Jan 2024 11:33:05 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Arnd Bergmann <arnd@...db.de>, Yu Liao <liaoyu15@...wei.com>,
Dawei Li <set_pte_at@...look.com>, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: ac97: fix build regression
On Wed, Jan 03, 2024 at 11:25:38AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The ac97_bus_type structure is no longer declared in this file:
>
> sound/ac97/bus.c: In function 'ac97_codec_add':
> sound/ac97/bus.c:112:27: error: 'ac97_bus_type' undeclared (first use in this function); did you mean 'bus_type'?
> 112 | codec->dev.bus = &ac97_bus_type;
> | ^~~~~~~~~~~~~
> | bus_type
> sound/ac97/bus.c:112:27: note: each undeclared identifier is reported only once for each function it appears in
> sound/ac97/bus.c: In function 'snd_ac97_codec_driver_register':
> sound/ac97/bus.c:191:28: error: 'ac97_bus_type' undeclared (first use in this function); did you mean 'ac97_bus_reset'?
> 191 | drv->driver.bus = &ac97_bus_type;
>
> Include the header that contains the declaration and make sure the definition
> is const but not static.
>
> Fixes: 66e82d219924 ("ALSA: mark all struct bus_type as const")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> sound/ac97/bus.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Ick, sorry about that, this didn't trigger in all of my build testing,
nor for 0-day, odd.
Anyway, thanks for the fix it is obviously correct:
Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists