linux-kernel - Re: [PATCH v4 7/7] cxl/memdev: Register for and process CPER events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 3 Jan 2024 10:41:13 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Ira Weiny <ira.weiny@...el.com>
CC: Dan Williams <dan.j.williams@...el.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@....com>, Shiju Jose <shiju.jose@...wei.com>,
	Yazen Ghannam <yazen.ghannam@....com>, "Davidlohr Bueso" <dave@...olabs.net>,
	Dave Jiang <dave.jiang@...el.com>, "Alison Schofield"
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, Ard
 Biesheuvel <ardb@...nel.org>, <linux-efi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-cxl@...r.kernel.org>, Bjorn Helgaas
	<bhelgaas@...gle.com>
Subject: Re: [PATCH v4 7/7] cxl/memdev: Register for and process CPER events

On Tue, 19 Dec 2023 16:29:08 -0800
Ira Weiny <ira.weiny@...el.com> wrote:

> Dan Williams wrote:
> > Ira Weiny wrote:
> > [..]  
> > > > and drop the = NULL above.  
> > > 
> > > Done.  
> > 
> > The NULL assignment was more about making it clear that
> > __free(pci_dev_put) will take no action until the pdev is acquired.
> > Otherwise, any future refactoring that introduces a 'return' before
> > @pdev is acquired needs to be careful to assign @pdev to NULL. So, just
> > include it in the declaration more as a __free() declaration style issue
> > than a correctness issue.  
> 
> I think he meant the assignment to cxlds.  At least that is the NULL
> assignment I took out.
> 
> Ira

yup.  The other one is correct as Dan pointed out.